Remove AccessToken::is_expired() #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
chlowell
requested review from
heaths,
RickWinter and
LarryOsterman
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the misleading AccessToken::is_expired() method and replaces it with a more robust token refresh mechanism while also adding test coverage and fixing an error in the proactive token refresh logic.
- Removed AccessToken::is_expired() and updated the token checking logic in cache and bearer token policy.
- Implemented a new helper (should_refresh) to determine token refresh timing.
- Enhanced error handling during token refresh and updated tests accordingly.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/identity/azure_identity/src/credentials/cache.rs | Replaced usage of is_expired() with should_refresh and updated test expiration. |
| sdk/core/azure_core/src/http/policies/bearer_token_policy.rs | Refactored token refresh logic and improved error handling during refresh. |
| sdk/core/azure_core/src/credentials.rs | Removed the is_expired() method as part of the deprecation. |
| sdk/core/azure_core/CHANGELOG.md | Documented the breaking change and bug fix. |
heaths
approved these changes
May 16, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Azure Identity SDK Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because it's unnecessary and its name is misleading. This PR also adds test coverage and fixes a bug: the policy currently returns errors from proactive refresh attempts even when it has a valid cached token. (There's no value in doing that because the client request could otherwise succeed.)